Skip to content
This repository was archived by the owner on Nov 8, 2021. It is now read-only.

Conversation

@michhar
Copy link
Contributor

@michhar michhar commented Nov 8, 2017

This line change would provide support for wxPython 4 (albeit still in beta). Merge if you think this will help. Note, it may break wxPython 3 support, but I don't actually see wxPython available from PyPi for versions other than 4. Hence this PR.

GridSizer needs extra arguments to work with the latest wxPython package (v4.0.0b2). These additional arguments provide vertical and horizontal gap of white space.

GridSizer needs extra arguments to work with the latest wxPython package (v4.0.0b2).  These additional arguments provide vertical and horizontal gap of white space.
@michhar michhar mentioned this pull request Nov 8, 2017
@huxuan
Copy link
Contributor

huxuan commented Nov 8, 2017

Good to know the gap from WxPython 4 is only one line fix. I will look into the changes and come up with actual response after some verification.

@huxuan huxuan self-requested a review November 9, 2017 02:51
@michhar
Copy link
Contributor Author

michhar commented Jan 11, 2018

@huxuan Have you happened to look into this further? Thanks.

@huxuan
Copy link
Contributor

huxuan commented Jan 12, 2018

Hi @michhar, thanks for following up. We are proposing another big change that will not support wxpython 4 but also support Python2 and Python3 at the same time. But I think this pull request is OK to be merged first. Actually the implementation is done and I was supposed to release it recently, but the business is still ongoing. Thansk for your patience anyway.

@huxuan huxuan merged commit e985c8e into microsoft:master Jan 12, 2018
@michhar
Copy link
Contributor Author

michhar commented Jan 30, 2018

@huxuan Thanks so much for your response. So, are you saying the next big version change will remove wxpython all together or add Python 3 support in addition? I'm very excited to hear about Python 3 support. Thanks again.

@huxuan
Copy link
Contributor

huxuan commented Jan 30, 2018

@michhar Yep. Actually the code is frozen and we are waiting for other business process before official release. Just be a little bit more patient. :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants