Added M365 connections to shared by iserrano76 · Pull Request #2090 · microsoft/CSS-Exchange

iserrano76 · 2024-05-09T14:05:46Z

Issue:
Added two functions to Shared in case any script needs a connection to M365.
One function for Exchange Online another function for AzureAD

Reason:
Unify the way we connect to M365.

Fix:
Both functions will do the following:

Verify if the module is installed, if not, install it after request confirmation.
Verify if the module is loaded, if not, load it.
Lastly, verify if any connection is present (we verify only one connection is present); if none, we offer to connect.
Important: we do not disconnect at anytime we just verify if we have an active session

Shared/Connect-M365.ps1

lusassl-msft

Requesting changes as there are a few things that should be changed (see comments).

dpaulson45

Please address all open comments then let me know when this is ready for the next review.

Shared/Connect-M365.ps1

Shared/ModuleHandle.ps1

dpaulson45

There might be some more things that I find later on, but here is a good starting point to address.

Shared/M365/EXOConnection.ps1

Shared/ModuleHandle.ps1

Shared/M365/GraphConnection.ps1

Shared/ModuleHandle.ps1

Shared/M365/GraphConnection.ps1

Shared/M365/EXOConnection.ps1

Shared/ModuleHandle.ps1

Shared/M365/EXOConnection.ps1

dpaulson45 · 2024-11-04T14:11:58Z

We should also look into adding pester testing here as well.

iserrano76 · 2024-11-18T10:36:55Z

/azp run

azure-pipelines · 2024-11-18T10:37:09Z

Azure Pipelines successfully started running 1 pipeline(s).

iserrano76 · 2024-11-26T14:22:49Z

/azp run

azure-pipelines · 2024-11-26T14:23:03Z

Azure Pipelines successfully started running 1 pipeline(s).

iserrano76 · 2024-11-26T15:39:53Z

/azp run

azure-pipelines · 2024-11-26T15:40:08Z

Azure Pipelines successfully started running 1 pipeline(s).

Shared/M365/EXOConnection.ps1

Shared/M365/GraphConnection.ps1

iserrano76 · 2024-11-27T16:54:23Z

/azp run

azure-pipelines · 2024-11-27T16:54:36Z

Azure Pipelines successfully started running 1 pipeline(s).

iserrano76 · 2024-11-27T17:09:33Z

/azp run

azure-pipelines · 2024-11-27T17:09:44Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45

Almost ready to go, after we get the next commit, let's also rebase this down to a single commit.

dpaulson45 · 2024-12-19T16:32:03Z

Shared/ModuleHandle.ps1

+        [Parameter(Mandatory = $false)]
+        [System.Version]$MinModuleVersion = $null


I guess we did address this by being in a loop, but the chances of you having a module that you are requesting be at the same min version is pretty low.

dpaulson45 · 2024-12-19T16:35:30Z

Shared/ModuleHandle.ps1

+        }
+        $installed = Get-InstalledModule @getParams
+
+        if ($null -eq $installed -or $installed.Name -notcontains $module) {


If we did find the module with the version that we are looking for, we should do Write-Verbose here that states at least the version to know if it is something newer and possibly something changed with the cmdlets that broke something.

@iserrano76 let's do this and rebase and then we should be good for one last review before merge.

iserrano76 · 2025-01-22T09:35:02Z

/azp run

azure-pipelines · 2025-01-22T09:35:15Z

Azure Pipelines successfully started running 1 pipeline(s).

Shared/ModuleHandle.ps1

iserrano76 · 2025-01-22T16:12:35Z

/azp run

azure-pipelines · 2025-01-22T16:12:47Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2025-01-22T16:25:48Z

@iserrano76 let's go ahead and rebase and squash this down to a single commit.

dpaulson45 · 2025-01-24T14:59:15Z

/azp run

azure-pipelines · 2025-01-24T14:59:30Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2025-01-24T15:24:18Z

Pending review from Lukas as well.

Shared/M365/EXOConnection.ps1

lusassl-msft · 2025-01-28T16:25:49Z

Shared/ModuleHandle.ps1

+        [Parameter(Mandatory = $false)]
+        [System.Version]$MinModuleVersion = $null


We could also think about removing the MinModuleVersion parameter and instead passing a key-value pair via Module parameter. This could be a dictionary (because they are strongly typed):

$modules = New-Object "System.Collections.Generic.Dictionary[String, Version]" $modules.Add("ModuleToLoad", "3.0.0.0")

We could then progress them one by one

Shared/ModuleHandle.ps1

dpaulson45 · 2025-02-05T15:15:46Z

/azp run

azure-pipelines · 2025-02-05T15:16:01Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2025-02-05T15:30:38Z

@lusassl-msft to review the final result, then we will squash this back down a commit and then merge.

lusassl-msft · 2025-02-05T17:05:30Z

Shared/ModuleHandle.ps1

+        Write-Verbose "Checking $m PowerShell Module"
+        $getParams = @{
+            Name        = $m
+            ErrorAction = 'SilentlyContinue'


@iserrano76 should we change this to ErrorAction = Stop and put the Get-InstalledModule into a try/catch? If we fail to query the modules for whatever reason, we treat it the same as if the module was not found. I think we should change this behavior.

If we are handling it properly, does it matter if we do the try/catch version?

No, it shouldn't matter then. If I understand the code correctly, we're trying to install the module if $installed is $null or does not contain $m (module x). Installed would be $null in case that Get-InstalledModule fail for whatever reason. This would mean we're trying installing a module which might be already there. That's my understanding here. Please correct me if I'm wrong.

lusassl-msft · 2025-02-05T17:09:41Z

Shared/ModuleHandle.ps1

+        [Parameter(Mandatory = $false)]
+        [System.Version]$MinModuleVersion = $null


I'm okay with both approaches. If you want to keep the current approach I'm okay with it.

Shared/ModuleHandle.ps1

lusassl-msft · 2025-02-11T16:41:49Z

Shared/ModuleHandle.ps1

+
+    $noFoundError = $true
+
+    foreach ($m in $Module) {


@iserrano76 Sorry to be so petty. Wouldn't it be better to return a final statement for each module that was passed when calling the Request-Module function? We support processing multiple modules in here but return just one state. If one of the modules fail and the remaining ones are processed successfully, we just return $false because one of them has failed. I think it would be better to put the module and final state to a hashtable and finally return it. What do you think?

Hi @lusassl-msft do not worry, it is a healthy discussion looking for the best solution, no problem at all 😉
Maybe it is easier to simplify and just allow one module each time instead of an array and return true or false for each one.
I think we are not going to request several modules.
What do you think?

That could make it more complicated for the caller to use. If that is the case, I would just adjust to only accept a single module and you have to test against each one.

Yep, let’s move to the one module approach then 👍

@iserrano76 are you able to make this change?

Yes, I am trying to find some time for testing.

iserrano76 · 2025-05-02T11:29:21Z

/azp run

azure-pipelines · 2025-05-02T11:29:35Z

Azure Pipelines successfully started running 1 pipeline(s).

Shared/ModuleHandle.ps1

dpaulson45 · 2025-05-02T16:18:06Z

@lukak-msft please review as soon as you can.

@iserrano76 please squash the commits down to 1 so we can clean this up and make it ready to merge once we are done reviewing.

iserrano76 · 2025-05-05T08:14:45Z

/azp run

azure-pipelines · 2025-05-05T08:14:58Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2025-05-28T17:38:28Z

@iserrano76 please squash this down to a single commit, then we will review and merge.

Copilot

Pull Request Overview

This PR adds standardized Microsoft 365 connection functions to the Shared module, providing unified ways to connect to Exchange Online and Microsoft Graph. The implementation includes module validation, installation prompts, and connection management with proper error handling.

Adds Request-Module function for PowerShell module management (install/verify)
Implements Connect-EXOAdvanced for Exchange Online connections with multi-session support
Implements Connect-GraphAdvanced for Microsoft Graph connections with scope validation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
Shared/ModuleHandle.ps1	Provides module installation and verification functionality
Shared/M365/EXOConnection.ps1	Exchange Online connection management with session handling
Shared/M365/GraphConnection.ps1	Microsoft Graph connection management with scope validation

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Shared/M365/GraphConnection.ps1

Shared/M365/EXOConnection.ps1

dpaulson45 · 2025-10-16T14:32:55Z

@iserrano76 please squash this down to a single commit, then we will review and merge.

iserrano76 · 2025-11-19T08:50:48Z

/azp run

azure-pipelines · 2025-11-19T08:51:02Z

Azure Pipelines successfully started running 1 pipeline(s).

iserrano76 · 2025-11-24T16:23:22Z

/azp run

azure-pipelines · 2025-11-24T16:23:38Z

Azure Pipelines successfully started running 1 pipeline(s).

dpaulson45 · 2026-01-23T20:45:31Z

@iserrano76 please squash this down to a single commit, then we will review and merge.

iserrano76 requested a review from a team as a code owner May 9, 2024 14:05

lusassl-msft reviewed May 9, 2024

View reviewed changes

Shared/Connect-M365.ps1 Outdated Show resolved Hide resolved

dpaulson45 reviewed May 9, 2024

View reviewed changes

lusassl-msft requested changes Jun 14, 2024

View reviewed changes

dpaulson45 requested changes Jun 19, 2024

View reviewed changes

Shared/Connect-M365.ps1 Outdated Show resolved Hide resolved

Shared/Connect-M365.ps1 Outdated Show resolved Hide resolved

Shared/Connect-M365.ps1 Outdated Show resolved Hide resolved

Shared/ModuleHandle.ps1 Show resolved Hide resolved

dpaulson45 reviewed Oct 9, 2024

View reviewed changes

dpaulson45 reviewed Nov 26, 2024

View reviewed changes

dpaulson45 reviewed Dec 19, 2024

View reviewed changes

dpaulson45 reviewed Jan 22, 2025

View reviewed changes

Shared/ModuleHandle.ps1 Outdated Show resolved Hide resolved

iserrano76 force-pushed the M365-Connection branch from dbfc7cf to 8507a98 Compare January 24, 2025 14:58

lusassl-msft requested changes Jan 28, 2025

View reviewed changes

lusassl-msft requested changes Feb 5, 2025

View reviewed changes

lusassl-msft reviewed Feb 11, 2025

View reviewed changes

dpaulson45 reviewed May 2, 2025

View reviewed changes

Shared/ModuleHandle.ps1 Outdated Show resolved Hide resolved

dpaulson45 reviewed May 2, 2025

View reviewed changes

Shared/ModuleHandle.ps1 Outdated Show resolved Hide resolved

Shared/ModuleHandle.ps1 Outdated Show resolved Hide resolved

lusassl-msft requested a review from Copilot September 15, 2025 14:04

Copilot AI reviewed Sep 15, 2025

View reviewed changes

Added M365 connections to shared

43d2e80

iserrano76 force-pushed the M365-Connection branch from 4ae5322 to 43d2e80 Compare November 19, 2025 08:47

Apply copilot suggestions

9425573

		[Parameter(Mandatory = $false)]
		[System.Version]$MinModuleVersion = $null

Conversation

iserrano76 commented May 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lusassl-msft left a comment

Choose a reason for hiding this comment

Uh oh!

dpaulson45 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dpaulson45 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dpaulson45 commented Nov 4, 2024

Uh oh!

iserrano76 commented Nov 18, 2024

Uh oh!

azure-pipelines bot commented Nov 18, 2024

Uh oh!

iserrano76 commented Nov 26, 2024

Uh oh!

azure-pipelines bot commented Nov 26, 2024

Uh oh!

iserrano76 commented Nov 26, 2024

Uh oh!

azure-pipelines bot commented Nov 26, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iserrano76 commented Nov 27, 2024

Uh oh!

azure-pipelines bot commented Nov 27, 2024

Uh oh!

iserrano76 commented Nov 27, 2024

Uh oh!

azure-pipelines bot commented Nov 27, 2024

Uh oh!

dpaulson45 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iserrano76 commented Jan 22, 2025

Uh oh!

azure-pipelines bot commented Jan 22, 2025

Uh oh!

Uh oh!

iserrano76 commented Jan 22, 2025

lusassl-msft Feb 11, 2025 •

edited

Loading