-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify signature of handler install #960
Merged
eddyashton
merged 10 commits into
microsoft:master
from
eddyashton:simple_install_signature
Mar 17, 2020
Merged
Simplify signature of handler install #960
eddyashton
merged 10 commits into
microsoft:master
from
eddyashton:simple_install_signature
Mar 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
- Coverage 68.13% 68.09% -0.05%
==========================================
Files 103 103
Lines 8146 8147 +1
==========================================
- Hits 5550 5547 -3
- Misses 2596 2600 +4
|
simple_install_signature@6059 aka 20200317.11 vs master ewma over 30 builds from 5763 to 6053 |
jumaffre
reviewed
Mar 17, 2020
jumaffre
reviewed
Mar 17, 2020
jumaffre
approved these changes
Mar 17, 2020
olgavrou
approved these changes
Mar 17, 2020
@eddyashton this is great! I think we should have the accessors only, and make sure they're exposed in doxygen/sphinx. |
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #914.
We have several parameters to tweak the behaviour of installed RPC handlers, and we're likely to add more. Rather than needing to specify all of these in the call to
install
(with signficant overload complications), they should be set manually on the few handlers they actually affect.This PR lets you set those parameters in 2 ways. Manually:
Or with chaining methods:
I prefer the second, but I think its worth keeping both in general.