Fix logging of pre-vote messages #7458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues related to pre-vote message handling in the Raft consensus implementation:
- Corrects logging by ensuring the
msgfield is properly set when converting betweenPreVoteandVotemessage types - Fixes inverted logic for detecting delayed/stale vote response messages based on leadership state transitions
- Updates the TLA specification to handle pre-vote response events
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tla/consensus/Traceccfraft.tla | Added recv_request_pre_vote_response event to the vote response handling condition |
| src/consensus/aft/raft.h | Fixed msg field assignments in vote message conversions and corrected the conditions for detecting delayed vote responses with updated explanatory comments |
achamayou
reviewed
Nov 13, 2025
achamayou
reviewed
Nov 13, 2025
achamayou
reviewed
Nov 13, 2025
achamayou
reviewed
Nov 13, 2025
achamayou
approved these changes
Nov 13, 2025
Co-authored-by: Amaury Chamayou <amaury@xargs.fr>
cjen1-msft
added a commit
to cjen1-msft/CCF
that referenced
this pull request
Nov 14, 2025
Co-authored-by: Amaury Chamayou <amaury@xargs.fr> Co-authored-by: Amaury Chamayou <amchamay@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While double checking the backport of the pre-vote I noticed that when separating the PreVote and Vote structs I had missed that the logging would still be using the original r.msg type and so print the wrong message type.
Additionally I noticed that I had the conditions with regards to when it is expected that you could get a delayed message inverted.
So receiving a
RequestVoteResponsefor a term while aPreVoteCandidatein that same term is instead possible, as a transition fromCandidatetoPreVoteCandidatevia a lost election and then timing out is possible, but unlikely.And it is receiving a
RequestPreVoteResponsefrom a term while aCandidatefor that same term should be impossible (see comment).