Skip to content

Update CheckQuorum and DropIgnoredMessage in ccfraft.tla #7374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
achamayou merged 6 commits into from
Oct 22, 2025
Merged

Update CheckQuorum and DropIgnoredMessage in ccfraft.tla #7374

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
566d797
Fix spec
cjen1-msft Oct 17, 2025
76e461d
Merge branch 'main' into fix-spec
achamayou Oct 20, 2025
8deed5f
Update tla/consensus/ccfraft.tla
cjen1-msft Oct 20, 2025
4c36b08
Add backref to raft.h
cjen1-msft Oct 20, 2025
ba6bcde
Merge branch 'main' into fix-spec
achamayou Oct 22, 2025
6284ba4
Merge branch 'main' into fix-spec
achamayou Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tla/consensus/ccfraft.tla
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -898,6 +898,9 @@ AdvanceCommitIndex(i) ==
CheckQuorum(i) ==
\* Check node is a leader (and therefore has not completed retirement)
/\ leadershipState[i] = Leader
\* There must be an active config which has a replica which is not this node
/\ \E c \in DOMAIN configurations[i]:
\E n \in configurations[i][c]: n /= i
/\ leadershipState' = [leadershipState EXCEPT ![i] = Follower]
/\ isNewFollower' = [isNewFollower EXCEPT ![i] = TRUE]
/\ UNCHANGED <<reconfigurationVars, messageVars, currentTerm, votedFor, candidateVars, leaderVars, logVars, membershipState>>
Expand Down Expand Up @@ -1177,6 +1180,9 @@ DropIgnoredMessage(i,j,m) ==
\/ /\ leadershipState[i] /= None
\* .. and it comes from a server outside of the configuration
/\ \lnot IsInServerSet(j, i)
\* raft.h::recv_request_vote
\* We specifically don't ignore RequestVoteRequest messages from unknown nodes
/\ m.type /= RequestVoteRequest
\* OR if recipient has completed retirement and this is not a request to vote or append entries request
\* This spec requires that a retired node still helps with voting and appending entries to ensure
\* the next configurations learns that its retirement has been committed.
Expand Down