Take version_lock when creating reserved Tx
#6633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyashton
added
5.x-todo
achamayou
approved these changes
Nov 12, 2024
ghost
pushed a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Amaury Chamayou <amchamay@microsoft.com> (cherry picked from commit 97e709b)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a lock, this is race-y access to
term_of_last_versionandrollback_count, which are normally protected byversion_lock. There's a comment suggesting this should already have been acquired, but it definitely hasn't in theMerkleTreeHistoryPendingTx::call()path. It's not clear to me where it ever was previously held.