OpenSSL 3.3: proper public key loading for EC keys #6613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtropets
force-pushed
the
f/6594-openssl-proper-ec-key-load
branch
from
ebe8f05
to
b355713
Compare
eddyashton
reviewed
Nov 5, 2024
eddyashton
approved these changes
Nov 5, 2024
Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com>
achamayou
approved these changes
Nov 5, 2024
achamayou
added
auto-backport
ghost
pushed a commit
that referenced
this pull request
Nov 5, 2024
Co-authored-by: Eddy Ashton <ashton.eddy@gmail.com> (cherry picked from commit dad86f8)
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check #6594 for more details.
Long story short, I was not able to figure out why we used
d2i_PublicKey, as I didn't really find an example of it in OpenSSL to be used together with*_from_datafunctions.I've tweaked the params to pass the raw key data there and simply called
EVP_PKEY_fromdatawithEVP_PKEY_PUBLIC_KEYselection, and it seems to work just well.