Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize number of TLC configuration files. #6511

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

lemmy
Copy link
Contributor

@lemmy lemmy commented Sep 27, 2024

Consolidate config files to reduce redundancy: The previous setup included multiple config files with mostly similar content. This commit replaces the individual config files with a single unified config file and introduces environment variables to handle differences.

Signed-off-by: Markus Alexander Kuppe <github.com@lemmster.de>
@lemmy lemmy marked this pull request as ready for review September 28, 2024 20:11
@lemmy lemmy requested a review from a team September 28, 2024 20:11
@achamayou achamayou added this pull request to the merge queue Sep 30, 2024
@achamayou achamayou removed this pull request from the merge queue due to a manual request Sep 30, 2024
@achamayou achamayou merged commit 2069c68 into microsoft:main Sep 30, 2024
17 checks passed
Copy link
Member

@heidihoward heidihoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lemmy for doing this! The duplication across cfg files meant it was tricky to always keep them all in sync

.github/workflows/tlaplus.yml Show resolved Hide resolved
@lemmy
Copy link
Contributor Author

lemmy commented Oct 1, 2024

A follow-up is to figure out how to run different logical configs in IDEs such as VSCode or the Toolbox.

@heidihoward
Copy link
Member

That's a good point, I guess we are now further away from #6490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tla TLA+ specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants