Decode msgpack and json consistently #566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our partially recursive failed to decode strings in lists and key-values, causing inconsistent behaviour depending on whether the
format
chosen was"json"
or"msgpack"
.Ideally they would be identical, and they are if we call
msgpack.unpackb(..., raw=False)
.As an associated change, the raw quote is passed as a byte-vector rather than a string. This does mean it appears as a long int list when looking at the raw JSON/Python, so its a prime candidate to be hex-encoded (#278).