Make error message for certs not found in user table clearer #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olgavrou
approved these changes
Nov 6, 2019
eddyashton
reviewed
Nov 6, 2019
src/node/rpc/frontend.h
Outdated
| @@ -503,7 +503,7 @@ namespace ccf | |||
| jsonrpc::error_response( | |||
| 0, | |||
| jsonrpc::CCFErrorCodes::INVALID_CALLER_ID, | |||
| "No corresponding caller entry exists."), | |||
| "Could not find matching user certificate."), | |||
There was a problem hiding this comment.
This is also called by members, where this error is incorrect. We could use callers->get_name(), but I think that will be ccf.user_certs?
There was a problem hiding this comment.
Maybe overkill, but as a general solution:
frontend.h:
virtual std::string invalid_caller_error_message() const {
return "Could not find matching actor certificate";
}
memberfrontend.h:
std::string invalid_caller_error_message() const override {
return "Could not find matching member certificate";
}
etc
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 78.12% 78.12% +<.01%
==========================================
Files 140 140
Lines 10473 10475 +2
==========================================
+ Hits 8181 8183 +2
Misses 2292 2292
|
|
|
|
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #525