Remove "all" target #513
Merged
Remove "all" target #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
achamayou
approved these changes
Nov 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
==========================================
- Coverage 78.24% 78.06% -0.17%
==========================================
Files 140 140
Lines 10462 10462
==========================================
- Hits 8185 8167 -18
- Misses 2277 2295 +18
|
|
|
|
|
olgavrou
approved these changes
Nov 4, 2019
|
|
eddyashton
added a commit
to eddyashton/CCF
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI only tests
TARGET=sgxandTARGET=virtual, but the default setting wasTARGET=all. Rather than trying to maintain 3 targets (with CMake's awkwardSTREQUALconstraints), this PR drops thealltarget completely. CMake branches compare directly against the expected target, rather than making assumptions about their inverse.