-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change C++ application entry point to remove dependency on frontends #3562
Merged
eddyashton
merged 13 commits into
microsoft:main
from
eddyashton:remove_public_network_tables
Feb 21, 2022
Merged
Change C++ application entry point to remove dependency on frontends #3562
eddyashton
merged 13 commits into
microsoft:main
from
eddyashton:remove_public_network_tables
Feb 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove_public_network_tables@42172 aka 20220218.41 vs main ewma over 20 builds from 41790 to 42144 Click to see tablemain
remove_public_network_tables
|
jumaffre
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, and requires a change in all C++ applications
We currently expose the full implementation of
RpcFrontend
, because we ask applications to extend this type to define their entry point. The decoupling ofFrontend
andEndpointRegistry
means this is unnecessary - applications define all of their actualy logic in anEndpointRegistry
, and wrap that in near-identical boiler plate to give us anRpcFrontend
.The benefit of this new approach is that the definition of several complex types like
ccf::NetworkTables
andccf::RpcFrontend
can remain part of the private implementation, and are not exposed to apps. However, it is a late-breaking change to the 2.0 API, so merits discussion.