-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluent theme] [P0] Add Fluent theme pack #5120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
changed the title
[DRAFT] [P0] Add themeability
[DRAFT] [P0] Add Fluent theme pack
Apr 8, 2024
compulim
changed the title
[DRAFT] [P0] Add Fluent theme pack
[P0] Add Fluent theme pack
Apr 8, 2024
compulim
requested review from
a-b-r-o-w-n,
cwhitten,
srinaath,
tdurnford and
beyackle2
as code owners
April 8, 2024 09:35
compulim
commented
Apr 8, 2024
compulim
commented
Apr 8, 2024
compulim
commented
Apr 8, 2024
This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 1, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 8, 2024
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
sendBoxMiddleware
andsendBoxToolbarMiddleware
, by @compulim, in PR #5120botframework-webchat-fluent-theme
package for applying Fluent UI theme to Web Chat, by @compulim, in PR #5120<ThemeProvider>
component to apply theme pack to Web Chat, by @compulim, in PR #5120Description
Apply a preset of middleware and style options in the following order: props > theme > default.
Design
<ThemeProvider>
is outside of Web Chat<ThemeProvider>
must not use any Web Chat hooks that requires<Composer>
<ThemeProvider>
can be applied at page-level, or just outer of<ReactWebChat>
<ThemeProvider>
can be nested/cascaded<Composer>
onlycomponent
package because it is where the default middleware is introducedcomponent
packageapi
package, because it feels more neutral, P1/P2component
package means React HTMLapi
package means React, that could mean React HTML or React NativesendBoxMiddleware
andsendBoxToolbarMiddleware
botframework-webchat-fluent-theme
package and wired visual regression testsSpecific Changes
botframework-webchat-fluent-theme
package and wired visual regression testssendBoxMiddleware
andsendBoxToolbarMiddleware
<BasicSendBox>
will be the default ofsendBoxMiddleware
<UploadButton>
will be the default ofsendBoxToolbarMiddleware
<ThemeProvider>
inbotframework-webchat-component
so it will merge props in<Component.Composer>
<ThemeProvider>
to API to broaden theme supportCHANGELOG.md
Review Checklist
Accessibility reviewed (tab order, content readability, alt text, color contrast)Browser and platform compatibilities reviewedCSS styles reviewed (minimal rules, noz-index
)Documents reviewed (docs, samples, live demo)Internationalization reviewed (strings, unit formatting)package.json
andpackage-lock.json
reviewedSecurity reviewed (no data URIs, check for nonce leak)