Support for aria-labels on link #3022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reader description"} format.
patniko
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
patniko
changed the title
compulim
reviewed
Mar 17, 2020
compulim
approved these changes
Mar 17, 2020
compulim
approved these changes
Mar 17, 2020
|
I am testing |
|
The Although it do include ES5 version, it didn't expose it properly (via I am fixing it by transpiling it before consuming/loading it. Will need to take another PR before we can produce a working build. |
This was referenced Mar 17, 2020
|
#3025 will fix this. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added support for custom attributes in the markdown renderer.
Description
Modern screen readers require aria-label attributes to be present on links, but the current markdown-it configuration doesn't support
aria-labelattributes. Adding support for attributes will enable users to set aria-label's and custom attributes on links in the Bot configuration interface.Appending {aria-label="Label description"} to the end of the link sets the aria-label attribute on the link when rendered.
Specific Changes
Imported the
markdown-it-attrsnpm package and added it to the renderer's configuration.--