Skip to content
This repository was archived by the owner on Oct 3, 2025. It is now read-only.

Conversation

ceciliaavila
Copy link
Contributor

@ceciliaavila ceciliaavila commented Mar 21, 2020

Description

This pull request updates the host bot to import the BotFrameworkHttp class from the
botbuilder.integration.aiohttp package.
We took the PR#2245 as a reference to update our Python host bot to the latest BotBuilder-Sample implementation.

Changes Made

  • Update host bot to use botbuilder.integration.aiohttp
  • Update to install the latest version of botbuilder-core
  • Update the allowed skill claims validator class
  • Update host bot to import the SkillHttpClient class from botbuilder.integration.aiohttp.skills
  • Add the adapter_with_error_handler class
  • Remove the old skill_http_client class
  • Add the skill_conversation_id_factory class

Testing

image

Copy link
Member

@axelsrz axelsrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also take a look at this file to have an idea on how to update the id factory

@ceciliaavila
Copy link
Contributor Author

Hi @axelsrz , @mrivera-ms , we applied the feedback. The PR is now ready to merge. Thanks!

@mrivera-ms mrivera-ms merged commit d074fbd into microsoft:master Mar 27, 2020
@ceciliaavila ceciliaavila deleted the update/python-host-bot branch April 7, 2020 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants