Replace custom SkillConversationIdFactory instance by SDK SkillConversationFactory #422
Description
With SDK 4.13.x we moved the SkillConversationFactory into the framework, this task involves deleting all the custom conversation ID factories and replace them with the ones provided by the SDK (see C# version here for example).
For JS, note that this will probably fix the "A potentially dangerous Request.Path value was detected from the client (:)." we see in the appInsights logs.
After reviewing the logs in detail, I noticed that this error only happens when the JS skills try to talk back to a bot.
The JS code seems to be creating the conversation ID using a ":":
And this trigger the exception we see in the logs.
The new conversation ID factory doesn't use microformat, it just uses a single GUID and this problem should not occur anymore.
Tracking
- C#
- JS
- Python