Skip to content

Conversation

@ivanov-dan
Copy link
Contributor

@ivanov-dan ivanov-dan commented May 1, 2019

Fixes #1471, fixes #1488

@msftclas
Copy link

msftclas commented May 1, 2019

CLA assistant check
All CLA requirements met.

@coveralls
Copy link

coveralls commented May 1, 2019

Coverage Status

Coverage decreased (-0.09%) to 57.144% when pulling 9c5a37d on v-dai/fixLUISModal into c15f3eb on master.

Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small change is needed to route external links to the appropriate command.

justinwilaby
justinwilaby previously approved these changes May 2, 2019
Copy link
Member

@cwhitten cwhitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests exercising the saga code in servicesExplorerSagas.spec.ts. Thank you!

@cwhitten cwhitten merged commit 6c3d0a4 into master May 7, 2019
@cwhitten cwhitten deleted the v-dai/fixLUISModal branch May 7, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Go to LUIS link does nothing LUIS No Models modal issues

7 participants