Fixed LUIS No Models modal issues #1471 #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanov-dan
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
|
|
justinwilaby
suggested changes
May 2, 2019
Contributor
justinwilaby
left a comment
justinwilaby
left a comment
There was a problem hiding this comment.
A small change is needed to route external links to the appropriate command.
justinwilaby
previously approved these changes
May 2, 2019
cwhitten
requested changes
May 3, 2019
Member
cwhitten
left a comment
cwhitten
left a comment
There was a problem hiding this comment.
Please add some tests exercising the saga code in servicesExplorerSagas.spec.ts. Thank you!
cwhitten
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1471, fixes #1488