-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md and set watermark based on provided options #66
Conversation
Fix was rolled back. Closing PR for now. :( |
Fix is has now been deployed. Watermark with websockets is functioning as expected. |
@EricDahlvang Nice work but I think the private attribute watermark should be '-' by default. Because now, if you use websockets (websocket = true) and don't initialize the value of the watermark you get the messages from the last watermark. But if you don't use websockets and don't initialize the value of the watermark you get the messages from the begining of the conversation. |
@nicolastomeo Thank you for pointing this out. I'll consult with some others, and get back to you. |
@nicolastomeo Apparently this is a modification the managers of this library are not interested in taking until there is a protocol change. Closing this PR so as to not waste people's time further. |
@EricDahlvang Thanks for the reply. |
@EricDahlvang Is this change merged to master or tagged? |
@bhushanvadgave No, this has not been merged. I am not a maintainer of this library, and the maintainers are not interested in taking this PR at this time. If you want to use WebSockets with watermark in DirectLineJS, you will need to make these changes in your own fork. |
@EricDahlvang Fine, thanks. |
fyi: Someone else had more luck getting this change into the library: #96 |
Remove: Watermark with websocket will be supported in the future.
The future is now! (this has been addressed)