-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add networkInformation
object to DLASE
#412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
reviewed
Jul 11, 2023
tdurnford
reviewed
Jul 11, 2023
Co-authored-by: TJ Durnford <tjdford@gmail.com>
ckkashyap
previously approved these changes
Jul 11, 2023
ckkashyap
approved these changes
Jul 11, 2023
tracyboehrer
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Added
networkInformation
option to assist detection of connection issues, by @compulim, in PR #412Designs
On iOS/iPadOS Safari, when connection change from Wi-Fi to cellular (say, walking away from coffee shop), the
WebSocket
object did not emiterror
event. It simply stalled. This only repros on iOS/iPadOS. It did not repro on Android Chrome.To detect network type change, we could use
networkInformation.type
. However, Network Information API is not implemented in Safari.We are adding a new option to allow web developers to provide a polyfill of W3C Network Information API. They could implement the polyfill using Server-Sent Events or native calls to NWPathMonitor.
When the
NetworkInformation
instance detected network change, it should:type
to current network type, such as"cellular"
,"wifi"
,"unknown"
, or"none"
(offline)change
eventUpon receiving the
change
event withtype
property changed, the chat adapter would terminate the current Web Socket connection and retries.Currently, despite Network Information API is implemented in modern browsers, the
type
property may not be implemented. A simple polyfill for thetype
property:Specific changes
networkInformation
toDirectLineStreaming
options