Skip to content

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Aug 31, 2020

Specific Changes

  • Move generated types out of directLine.ts to types.ts
    • Alphabetically sorts the types and their properties
  • Change from import * as BFSE from 'botframework-streaming' to import { ... } from 'botframework-streaming/browser/index-browser'
  • Update CHANGELOG.md with corresponding changes

Testing

The change in directLineStreaming.ts to point to 'botframework-streaming/browser/index-browser' has been validated with unit tests and tested E2E with botframework-webchat@4.10.0 via the following matrix:

botframework-streaming@4.9.2 botframework-streaming via microsoft/botbuilder-js#2753
HTTP
Websockets via DL-ASE

This also serves as the starting point for addressing issue #288.

@stevengum stevengum marked this pull request as ready for review September 1, 2020 22:37
@stevengum stevengum changed the title refactor generated types to new types.ts Use botframework-streaming browser dist; misc. refactoring and linting Sep 1, 2020
@stevengum
Copy link
Member Author

Closing in favor of #306

@stevengum stevengum closed this Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant