Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extensions typescript errors #9524

Merged
merged 4 commits into from
Mar 2, 2023
Merged

fix: extensions typescript errors #9524

merged 4 commits into from
Mar 2, 2023

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Feb 27, 2023 •
edited
Loading

Description

Fixed typescript issues with extensions and enabled types checking for extensions

#minor

@OEvgeny OEvgeny marked this pull request as ready for review March 1, 2023 04:00
@coveralls
Copy link

Coverage Status

Coverage: 54.556%. Remained the same when pulling 66f8320 on OEvgeny:fix/ts-errors into ff0bf23 on microsoft:main.

a-b-r-o-w-n
a-b-r-o-w-n approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks

@a-b-r-o-w-n a-b-r-o-w-n merged commit 12d2579 into microsoft:main Mar 2, 2023
@OEvgeny OEvgeny deleted the fix/ts-errors branch March 2, 2023 18:23
@cwhitten cwhitten mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdurnford tdurnford tdurnford left review comments

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OEvgeny @coveralls @a-b-r-o-w-n @tdurnford