-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a11y: more fixes for the last pass #9396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
force-pushed
the
a11y/issues-2
branch
from
September 30, 2022 20:26
1f7986c
to
dbb1987
Compare
OEvgeny
requested review from
benbrown,
natalgar,
VamsiModem,
cwhitten,
boydc2014,
a-b-r-o-w-n,
srinaath and
tdurnford
as code owners
October 3, 2022 16:28
tdurnford
approved these changes
Oct 3, 2022
cwhitten
approved these changes
Oct 3, 2022
erquirogasw
pushed a commit
to southworks/BotFramework-Composer
that referenced
this pull request
Oct 13, 2022
This reverts commit d2e133d.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a11y: disable subscriptions input if no subscriptions available
Fixes 75832
Screenshots
a11y: fix collapse button aria
Fixes 75830
Screenshots
a11y: restore focus on toolbar menu dismiss event
Fixes 75833
Screenshots
a11y: fix code-editor properties tree aria
Fixes 75854
Screenshots
a11y: scope color adjustments to disabled forced-colors
Fixes 75828
Screenshots
#minor