fix: improve portfinder usage #9366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure we use the latest `portfinder` version available - Adjust default start port for every portfinder call, so if two calls happen simultaneously, they don't try to acquire the same port - Add logging for portfinder errors and port used before listening - If portfinder fails, try using preferred port, letting listen to fail and provide more sensible error
OEvgeny
force-pushed
the
fix/portfinder
branch
from
e410bd8
to
0001599
Compare
OEvgeny
requested review from
benbrown,
tonyanziano,
natalgar,
VamsiModem,
cwhitten,
boydc2014,
a-b-r-o-w-n,
beyackle,
srinaath and
tdurnford
as code owners
cwhitten
approved these changes
Aug 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
portfinderversion availableportfindercall, so if two calls happen simultaneously, they don't try to acquire the same portportfindererrors and port used before listeningportfinderfails, try using preferred port, letting listen to fail and provide more sensible error#minor