a11y: ensure there is only one main landmark #9074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant main landmarks and add the landmark for pages where it is not defined Contains the following changes: - Removed MainContent component as it's not beeing used anywhere - Remove main role duplication from Disigner pages - Add main role to plugin pages - (Unrelated improvement) Link Language modal search field label with the search field
OEvgeny
requested review from
cwhitten,
boydc2014,
a-b-r-o-w-n,
beyackle,
srinaath,
tonyanziano,
benbrown,
tdurnford,
natalgar and
VamsiModem
as code owners
OEvgeny
commented
Mar 26, 2022
tonyanziano
reviewed
Mar 28, 2022
tonyanziano
approved these changes
Mar 28, 2022
tonyanziano
pushed a commit
that referenced
this pull request
May 12, 2022
* a11y: ensure there is only one main landmark (#9074) * a11y: ensure there is only one main landmark Remove redundant main landmarks and add the landmark for pages where it is not defined Contains the following changes: - Removed MainContent component as it's not beeing used anywhere - Remove main role duplication from Disigner pages - Add main role to plugin pages - (Unrelated improvement) Link Language modal search field label with the search field * Fix lint issues * a11y: Add aria-required attribute to Form Editor required fields (#9079) * a11y: Add aria-required attribute to FormEditor required fields These fields are visually indicated as required. so add `aria-required` attribute for screenreaders. * Address review comments * a11y: fix aria-label content (#9092) Aria label should start from visible content. This PR fixes the occurrence pointed out in the linked bug. * a11y: fix project tre roles and aria (#9093) This improves aria for the Project Tree control. Includes the following changes: - Remove redundant aria-label causing two elements in the chain to have the same name - Remove redundant tabIndex and move keyboard handler to the place where the keyboard event happens - Make aria-labels to follow the rule: visible content goes first in the label * a11y: add support for intellisense (#9091) * a11y: add support for intellisense The PR adds accessibility properties for the intellisense component, wires them with input components and fixes some observations. List of changes: - Added `aria` attributes set into `Intellisense` component, so it to be passed down to any input rendered - Updated fields. where it makes sense. to include a11y parameters passed by Intellisense - Added scrollIntoView for CompletionElement to ensure the selected element is in the view - Refactored CompletionList a11y properties. Now list has a listbox role when showing suggestions * Fix tests * Fix indent * Fix nit * a11y: address accessibility insights issues (#9148) * a11y: improve debug header aria * Add aria attributes * Exclude empty button from keyboard navigation * a11y: enforce HelpTooltip aria * Make HelpTooltip `aria-label` property required * Remove `aria-hidden` attribute from the help tooltip icon * Add missing aria-labels and roles * Allow focusing tooltips inside menu items * Rework types * a11y: add aria for knowledge base buttons * Add `aria-label` for icon-only buttons * a11y: improve publish screen aria * Add aria for controls * Add column names * a11y: split button aria * Add accessible split button component * Refactor Library split button * a11y: package manager aria * add missing aria labels for controls * Revert "a11y: split button aria" This reverts commit da7e713. * a11y: split button aria * Add accessible split button component * Refactor Library split button * Refactor Chat header split button * a11y: debug panel aria improvements * Add label for bot picker * a11y: upgrade webchat * Upgrade WebChat to the latest version as it fixes some accessibility issues * Revert "a11y: upgrade webchat" This reverts commit 9762cf0. * a11y: improve get started panel aria * Add close button label * fix lint * chore: update electron to currently supported version * Trigger build * Use Electron v14.2.6 * Trigger build * Fix mac signing process * Implement custom electron build fetching * Revert "chore: update electron (#9056)" This reverts commit 226b4df. * fix path
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove redundant main landmarks and add the landmark for pages where it is not defined
Contains the following changes:
Task Item
Screenshots
#minor