a11y: show one modal at once for bot creation flow #9047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OEvgeny
requested review from
cwhitten,
boydc2014,
a-b-r-o-w-n,
beyackle,
srinaath,
tonyanziano,
benbrown,
tdurnford,
natalgar and
VamsiModem
as code owners
tonyanziano
approved these changes
Mar 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening multiple modals simultaneously confuses screen readers. This fixes the issue by allowing only one modal to be showed at the same time.
Task Item
Screenshots
Before
The
AzureBotDialogis placed beneath "Select the template" dialog (notice double dark overlay)After
#minor