This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Add delete form dialog to Composer server API#4553
Merged
GeoffCoxMSFT merged 3 commits intomainfrom Oct 27, 2020
Merged
Conversation
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
approved these changes
Oct 27, 2020
|
|
||
| const currentProject = await BotProjectService.getProjectById(projectId, user); | ||
| if (currentProject !== undefined) { | ||
| await currentProject.deleteFormDialog(dialogId); |
Contributor
There was a problem hiding this comment.
do we want a try catch here with 500 response?
| const updatedProject = await BotProjectService.getProjectById(projectId, user); | ||
| res.status(200).json({ id: projectId, ...updatedProject.getProject() }); | ||
| } else { | ||
| res.status(404).json({ |
Contributor
There was a problem hiding this comment.
nit: the error for when the caller doesn't provide project id should be different
hatpick
changed the title
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Soroush <hatpick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deleting a form dialog requires deleting form dialog assets which are all contained within a folder under dialogs.
Task Item
#minor
#4505
Screenshots
N/A