Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

feat: install remote extensions from npm#4224

Merged
a-b-r-o-w-n merged 26 commits intomainfrom
abrown/extensions/install-from-npm
Sep 23, 2020
Merged

feat: install remote extensions from npm#4224
a-b-r-o-w-n merged 26 commits intomainfrom
abrown/extensions/install-from-npm

Conversation

@a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Sep 21, 2020

Description

Adds apis to install/uninstall extensions from npm.

Includes other various refactors as well.

Task Item

closes #3992

tonyanziano
tonyanziano previously approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tonyanziano
tonyanziano previously approved these changes Sep 22, 2020
View reviewed changes
@coveralls
Copy link

coveralls commented Sep 22, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 55.605% when pulling ac10396 on abrown/extensions/install-from-npm into def9f80 on main.

@a-b-r-o-w-n a-b-r-o-w-n changed the title feat: install remote extensions from npm [HOLD] feat: install remote extensions from npm Sep 22, 2020
@a-b-r-o-w-n a-b-r-o-w-n changed the title [HOLD] feat: install remote extensions from npm feat: install remote extensions from npm Sep 23, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit d361ddb into main Sep 23, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/extensions/install-from-npm branch September 23, 2020 00:41
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Sep 23, 2020
Merged
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Sep 28, 2020
@alanlong9278
Merge branch 'main' into julong/zoom-in-out
e181f34 
* main:
  fix: update l10n file (microsoft#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251)
  fix: split qna resource to another template (microsoft#4212)
  feat: UI Schema - Recognizer (microsoft#4135)
  fix: Change http to https for petstore.swagger.io calls (microsoft#4238)
  feat: install remote extensions from npm (microsoft#4224)
  fix: refactored select skill ui-plugin (microsoft#4207)
  feat: Added fieldSets to UIOptions (microsoft#4231)
  fix: New LG template not sync to other locale files (microsoft#4230)
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
@alanlong9278
Merge branch 'main' into julong/zoom-in-out
3fc8318 
* main:
  fix: update l10n file (microsoft#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251)
  fix: split qna resource to another template (microsoft#4212)
  feat: UI Schema - Recognizer (microsoft#4135)
  fix: Change http to https for petstore.swagger.io calls (microsoft#4238)
  feat: install remote extensions from npm (microsoft#4224)
  fix: refactored select skill ui-plugin (microsoft#4207)
  feat: Added fieldSets to UIOptions (microsoft#4231)
  fix: New LG template not sync to other locale files (microsoft#4230)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
@alanlong9278
Merge branch 'main' into julong/zoom-in-out
38a15f2 
* main:
  fix: update l10n file (#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (#4251)
  fix: split qna resource to another template (#4212)
  feat: UI Schema - Recognizer (#4135)
  fix: Change http to https for petstore.swagger.io calls (#4238)
  feat: install remote extensions from npm (#4224)
  fix: refactored select skill ui-plugin (#4207)
  feat: Added fieldSets to UIOptions (#4231)
  fix: New LG template not sync to other locale files (#4230)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@a-b-r-o-w-n @tonyanziano
feat: install remote extensions from npm (microsoft#4224)
46552aa 
* move server tests into local __tests__ directories

* add tests for extensions controller

* set up jest for extension package

* add build config

* add test for manifest store

* change logger prefix

* extract npm command to helper util

* add missing dependency

* rename env variables

* use different manifest for tests

* rename parameter for clarity

* load all extensions on server start

* more name refactoring

* fix test mocks

* set up tests better

* load all extensions on server start

* refactor npm signature

* further scope npm search keywords

* apply code review feedback

* disable format message warnings for test

* reduce console noise in tests

* make console override safer

* load plugins from correct directory in test

Co-authored-by: Tony Anziano <tonyanziano5@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

1 more reviewer

@tonyanziano tonyanziano tonyanziano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Users can install and uninstall extensions from npm

3 participants

@a-b-r-o-w-n @coveralls @tonyanziano