fix: #2692 Tabbing / clicking / returning out of a number field round your input

[LouisEugeneMSFT]

Description

The field (Composer/packages/extensions/adaptive-form/src/components/fields/NumberField.tsx) was always rounding numbers to be integers since onValidate calls updateValue(0).
In the case of floats, updateValue(0) would call getFloat(value, 0), which would call .toFixed(0).

This is because the step variable was used in different places for different purposes. In the case of getFloat it was used both for incrementing and rounding, which is incorrect.

The PR therefore makes the rounding "amount" a separate variable (floatNumberOfDecimals).

Task Item

fixes #2692

Screenshots

[a-b-r-o-w-n]

If possible, try to add a test case for this. Fabric does not make testing the SpinButton very easy, so just do what you can.

[coveralls]

Coverage increased (+0.004%) to 47.818% when pulling 4e99a49 on LouisEugeneMSFT:leugene/issue2692 into 803e639 on microsoft:master.

[cwhitten]

@vishwacsena @tomlm can you comment to the introduction of multipleOf to specify precision on a number type? See "Validations" on https://cswr.github.io/JsonSchema/spec/basic_types/

[luhan2017]

@cwhitten , It seems I have some misunderstanding here, I was trying to say that
For the NumberInput, we can use the outputFormat(=formatNumber(this.value, 2)) property to define the precision of the number type.
Here is an example:

This means user can set precision of the output by formatNumber expression in LG.
This seems not relate to what you want.
I don't quite understand what is the multipleOf used for. Do you mean to define the precision of a number variable in the component schema?

[cwhitten]

@luhan2017 @LouisEugeneMSFT let's take this and continue discussion to determine if we want to allow the the number type to include a precision option, so that you don't need to format using lg.