Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

style: Visual Editor node menu position, edge menu background#3194

Merged
cwhitten merged 4 commits intomasterfrom
visual/icon
May 27, 2020
Merged

style: Visual Editor node menu position, edge menu background#3194
cwhitten merged 4 commits intomasterfrom
visual/icon

Conversation

@yeze322
Copy link
Contributor

@yeze322 yeze322 commented May 27, 2020

Description

follows #3125
closes #3194

Those styles have stayed there for months without taking any effect; after 3125 they started to work but unfortunately took wrong effects. Removing them can fix style issues.

(The style issue on Edge Menu not always appears, it's related to fabric-ui version)

Before

Node Menu Edge Menu
image image

After

Node Menu Edge Menu
image image

Task Item

Screenshots

@yeze322 yeze322 changed the title style: Visual Editor node menu position style: Visual Editor node menu position, edge menu background May 27, 2020
@cwhitten cwhitten merged commit 5d3ae79 into master May 27, 2020
@cwhitten cwhitten deleted the visual/icon branch May 27, 2020 20:38
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…oft#3194)

* fix node menu style

* remove EdgeMenu button background

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants