This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Merged
Conversation
a-b-r-o-w-n
requested review from
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
Contributor
|
Looks neat, @liweitian please check this out |
srinaath
reviewed
May 26, 2020
Composer/packages/client/src/components/CreationFlow/DefineConversation/index.tsx
Show resolved
Hide resolved
a-b-r-o-w-n
commented
May 28, 2020
Composer/packages/client/src/components/CreationFlow/DefineConversation/index.tsx
Show resolved
Hide resolved
| const createConfig = require('./createConfig'); | ||
|
|
||
| module.exports = testingLib; | ||
| module.exports.hooks = hooksLib; |
Contributor
Author
There was a problem hiding this comment.
I would like to have done something like
import { act } from '@bfc/test-utils/hooks'`But I couldn't figure out how to expose that in the typings correctly. If anyone has some TS wizardry, I would appreciate.
Contributor
Author
|
Going to merge this to get the hooks testing utils. |
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add react-hooks testing lib * add useForm hook * use useForm in a couple of forms * remove comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have various forms through out the client app which all handle validation in similar ways. I have been thinking we need a form hook for a while so I decided to whip up something as a POC.
Task Item
#minor