This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Conversation
zhixzhan
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
boydc2014
suggested changes
May 20, 2020
Contributor
boydc2014
left a comment
boydc2014
left a comment
There was a problem hiding this comment.
Please also update the lg package to fix the parsing issue.
boydc2014
reviewed
May 20, 2020
Contributor
Author
Sure, there are some upgrade issue haven't resolve, added |
Contributor
FYI, the js fix is in master, you should be unblocked now |
zhixzhan
force-pushed
the
zhixzhan/lgremove
branch
from
22d6e15 to
35847e5
Compare
Contributor
Author
updated. |
boydc2014
approved these changes
May 26, 2020
cwhitten
approved these changes
May 26, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* do not remove * install latest lgparser * upgrade Expression package * fix atob in worker * remove dead code * update lg package Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Task Item
close #3136
close #3168
Screenshots