This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Conversation
zidaneymar
requested review from
benbrown,
boydc2014,
carlosscastro and
luhan2017
as code owners
gabog
reviewed
May 21, 2020
gabog
previously approved these changes
May 21, 2020
Contributor
gabog
left a comment
gabog
left a comment
There was a problem hiding this comment.
Check my comment and see if it makes sense.
Also, you may want to write a unit test for this. You can use MemoryStorage for it.
Contributor
Author
I have added the unit tests, referring to the SkillHandlerTests in botbuilder-dotnet |
luhan2017
reviewed
May 28, 2020
|
|
||
| // Create the storage key based on the SkillConversationIdFactoryOptions. | ||
| var conversationReference = options.Activity.GetConversationReference(); | ||
| var skillConversationId = $"{options.FromBotId}-{options.BotFrameworkSkill.AppId}-{conversationReference.Conversation.Id}-{conversationReference.ChannelId}-skillconvo"; |
Contributor
There was a problem hiding this comment.
what does this "skillconvo" mean?
Contributor
There was a problem hiding this comment.
It is just an arbitrary string, so you know that is a skill conversation ID when debugging, it not required at all, is up to the dev what the ID looks like.
luhan2017
approved these changes
May 29, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* use IStorage for id factory * fix conversationId * add ConversationIdFactory unit tests * renaming tests Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
use IStorage rather than concurrent dictionary for id factory in Composer
Task Item
fixes #3133
Screenshots