This repository was archived by the owner on Jul 9, 2025. It is now read-only.
ci: add base path for coveralls action#3131
Merged
a-b-r-o-w-n merged 3 commits intomasterfrom May 19, 2020
Merged
Conversation
a-b-r-o-w-n
requested review from
beyackle,
corinagum,
srinaath and
tonyanziano
as code owners
beyackle
approved these changes
May 19, 2020
a-b-r-o-w-n
commented
May 19, 2020
| "chalk": "^4.0.0", | ||
| "concurrently": "^4.1.0", | ||
| "coveralls": "^3.0.7", | ||
| "coveralls": "^3.1.0", |
Contributor
Author
There was a problem hiding this comment.
This wasn't required to get the fix. I think the problem was that coveralls wasn't recognizing the file paths correctly since they were relative to the Composer directory, but the action is run in the root of the project. So something like ./packages/client/src/foo.ts wasn't found in the project root, only from the Composer directory.
cwhitten
approved these changes
May 19, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add base path for coveralls action * bump coveralls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes coveralls reporting. Report here
Task Item
refs #2570
Screenshots