Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: remove luisauthoringkey and region from provision #3108

Merged
cwhitten merged 5 commits into from
May 27, 2020
Merged

fix: remove luisauthoringkey and region from provision #3108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8ccb99
change readme
VanyLaw May 17, 2020
f0db5d3
remove luisauthoringkey and region from provision script
VanyLaw May 17, 2020
3b5ca88
Merge branch 'master' into wenyluo/doc
VanyLaw May 19, 2020
be067ce
Merge branch 'master' into wenyluo/doc
VanyLaw May 26, 2020
69e0bf2
Merge branch 'master' into wenyluo/doc
cwhitten May 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions Composer/plugins/samples/assets/shared/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,11 @@ This project includes a script that can be used to provision the resources neces
It will look like this:
```
{
"publishName": "<NAME OF YOUR RESOURCE GROUP>",
"location": "westus",
"subscriptionID": "<YOUR SUBSCRIPTION ID>",
"accessToken": "<SOME VALUE>",
"name": "<NAME OF YOUR RESOURCE GROUP>",
"appPassword": "<YOUR APP PASSWORD>",
"luisAuthoringRegion": "westus",
"environment": "<ENVIRONMENT>",
"provision": {
"settings": {
"applicationInsights": {
"InstrumentationKey": "<SOME VALUE>"
},
Expand All @@ -46,8 +44,7 @@ It will look like this:
},
"MicrosoftAppId": "<SOME VALUE>",
"MicrosoftAppPassword": "<SOME VALUE>"
},
"accessToken": "<SOME VALUE>"
}
}```

When completed, you will see a message with a JSON "publishing profile" and instructions for using it in Composer.
Expand Down
4 changes: 0 additions & 4 deletions Composer/plugins/samples/assets/shared/scripts/provisionComposer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ const usage = () => {
['environment', 'Environment name (Defaults to dev)'],
['location', 'Azure Region (Defaults to westus)'],
['appId', 'Microsoft App ID (Will create if absent)'],
['luisAuthoringKey', 'LUIS Authoring Key to use when publishing to LUIS'],
['luisAuthoringRegion', 'Azure Region used with LUIS (defaults to westus)'],
['tenantId', 'ID of your tenant if required (will choose first in list by default)'],
['createLuisResource', 'Create a LUIS resource? Default true'],
['createLuisAuthoringResource', 'Create a LUIS authoring resource? Default true'],
Expand Down Expand Up @@ -85,8 +83,6 @@ const appPassword = argv.appPassword;
const environment = argv.environment || 'dev';
const location = argv.location || 'westus';
const appId = argv.appId; // MicrosoftAppId - generated if left blank
const luisAuthoringKey = argv.luisAuthoringKey; // not currently used
const luisAuthoringRegion = argv.luisAuthoringRegion || 'westus'; // not currently used

// Get option flags
const createLuisResource = argv.createLuisResource == 'false' ? false : true;
Expand Down