This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: allow tenantId to be specified in provisioning script#3084
Merged
fix: allow tenantId to be specified in provisioning script#3084
Conversation
benbrown
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
benbrown
changed the title
srinaath
reviewed
May 15, 2020
| const createCosmosDb = argv.createCosmosDb == 'false' ? false : true; | ||
| const createStorage = argv.createStorage == 'false' ? false : true; | ||
| const createAppInsignts = argv.createAppInsignts == 'false' ? false : true; | ||
| var tenantId = argv.tenantId ? argv.tenantId : ''; |
Contributor
There was a problem hiding this comment.
const here and maybe we can do the || instead of ternary
| // the returned access token will almost surely have a tenantId. | ||
| // use this as the default if one isn't specified. | ||
| // otherwise, fetch a list and use the first, but print available options. | ||
| if (token.tenantId) { |
Contributor
There was a problem hiding this comment.
Maybe token && token.tenantId?
Member
|
taking this now to kick a build off (0.0.4) |
cwhitten
approved these changes
May 15, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…#3084) * allow tenantId to be specified * use default tenantid Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In provision script, use the tenantId provided by the login instead of choosing the first in the list of available tenants.
Also, allow user to specify a tenantId as a cli parameter.
Task Item
fixes #3075