This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Goto Begin Dialog after clicking dialog#3079
Merged
cwhitten merged 6 commits intomicrosoft:masterfrom May 15, 2020
tdurnford:fix/select-dialog
Merged
fix: Goto Begin Dialog after clicking dialog#3079cwhitten merged 6 commits intomicrosoft:masterfrom tdurnford:fix/select-dialog
cwhitten merged 6 commits intomicrosoft:masterfrom
tdurnford:fix/select-dialog
Conversation
tdurnford
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten,
srinaath and
tonyanziano
as code owners
cwhitten
approved these changes
May 15, 2020
cwhitten
suggested changes
May 15, 2020
cwhitten
approved these changes
May 15, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix: Goto Begin Dialog after clicking dialog * Minor edit Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
designPageLocationobject being included in theusEffectdependency array causes the selected trigger to be set to theBeginDialogtrigger after the user selects the dialog becausedesignPageLocation.selectedgets set to null when a trigger isn't selected which causes the hook to execute unnecessarily. RemovingdesignPageLocationfrom theusEffectdependency array resolves the issue.Task Item
Closes #3070
Screenshots