Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

fix: duplicated key in recent bot list#3069

Merged
cwhitten merged 4 commits intomicrosoft:masterfrom
liweitian:recentBotsOrder
May 15, 2020
Merged

fix: duplicated key in recent bot list#3069
cwhitten merged 4 commits intomicrosoft:masterfrom
liweitian:recentBotsOrder

Conversation

@liweitian
Copy link
Contributor

@liweitian liweitian commented May 15, 2020

Description

The recent bot list use BotName as the key. The key maybe duplicated which causes the bug.

Task Item

Closes #3048

Screenshots

@boydc2014 boydc2014 changed the title fix: same key issue fix: duplicated key in recent bot list May 15, 2020
@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label May 15, 2020
@cwhitten cwhitten merged commit 208f789 into microsoft:master May 15, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling c9ba980 on liweitian:recentBotsOrder into 5f8181b on microsoft:master.

lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* fix same key in a list issue

* remove console

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Approved to merge approved, waiting to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants