This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Fixed missing publish targets in Composer Electron#3055
Merged
tonyanziano merged 2 commits intomasterfrom May 14, 2020
Merged
fix: Fixed missing publish targets in Composer Electron#3055tonyanziano merged 2 commits intomasterfrom
tonyanziano merged 2 commits intomasterfrom
Conversation
tonyanziano
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten and
srinaath
as code owners
beyackle
approved these changes
May 14, 2020
a-b-r-o-w-n
approved these changes
May 14, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
azurePublishandazureFunctionPublishplugins have a hard dependency on@bfc/libs/bot-deploybut do not include it in theirpackage.json. Source 1 Source 2The plugin code should have been broken in the web app as well, but the only reason it was working is because of the yarn monorepo hoisting the missing dependencies (
@bfc/libs/bot-deploy).This missing dependency then caused the plugin initialization to break in the packaged Electron app where there are no hoisted dependencies.
Task Item
Fixes #3053
Screenshots