Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

fix: Update schema#3044

Merged
cwhitten merged 3 commits intomasterfrom
luhan/schemaFix
May 14, 2020
Merged

fix: Update schema#3044
cwhitten merged 3 commits intomasterfrom
luhan/schemaFix

Conversation

@luhan2017
Copy link
Contributor

@luhan2017 luhan2017 commented May 14, 2020

Description

Update schema, which brings in the SkillDialog->BeginSkill renaming.
We've verified that 4.9.1 didn't fix the dialog id issue, so I reverted the 4.9.1 update.

Task Item

fixes #3042

Screenshots

@luhan2017 luhan2017 changed the title Update to 4.9.1 and Update schema fix: Update to 4.9.1 and Update schema May 14, 2020
@github-actions
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling e0fc600 on luhan/schemaFix into 7c59824 on master.

@luhan2017 luhan2017 requested a review from yeze322 as a code owner May 14, 2020 08:52
@luhan2017 luhan2017 changed the title fix: Update to 4.9.1 and Update schema fix: Update schema May 14, 2020
@hibrenda
Copy link
Contributor

Verified the skill can be called local to local with the schema updates. no 500 error.

@cwhitten cwhitten merged commit c9578a6 into master May 14, 2020
@cwhitten cwhitten deleted the luhan/schemaFix branch May 14, 2020 14:52
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Update to 4.9.1 and Update schema

* rename skillDialog in composer (microsoft#3045)

* revert the 4.9.1 update

Co-authored-by: Long Alan <julong@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants