Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

fix: adjust shape of publishing configuration for clarity#3029

Merged
a-b-r-o-w-n merged 6 commits intomasterfrom
benbrown/publishshape
May 13, 2020
Merged

fix: adjust shape of publishing configuration for clarity#3029
a-b-r-o-w-n merged 6 commits intomasterfrom
benbrown/publishshape

Conversation

@benbrown
Copy link
Contributor

@benbrown benbrown commented May 13, 2020 •
edited
Loading

Description

This introduces a slight change to the shape of the publishing configurations.

  • Rename "provision" field to "settings"
  • Rename "publishName" to "name"
  • Introduce optional "hostname" and "luisResource" name to support non-standard web app or luis resource names (otherwise required to be in name-env format)

Also slight adjustment to plugin parameters:

  • Rename settings key to fullSettings (contains all settings from bot including those managed inside composer)
  • Rename "name" field to "profileName"

includes fixes to azurePublish, azureFunctionsPublish and localPublish plugins

Fixes #3020

@benbrown benbrown changed the base branch from stable to master May 13, 2020 17:06
@github-actions
Copy link

github-actions bot commented May 13, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 8750833 on benbrown/publishshape into ab5cc0c on master.

@benbrown benbrown marked this pull request as ready for review May 13, 2020 17:51
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 13, 2020
Closed
@a-b-r-o-w-n a-b-r-o-w-n merged commit 677a95a into master May 13, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the benbrown/publishshape branch May 13, 2020 22:18
@VanyLaw VanyLaw mentioned this pull request May 14, 2020
Closed
8 tasks
@hibrenda hibrenda mentioned this pull request May 14, 2020
Closed
8 tasks
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@benbrown @cwhitten
fix: adjust shape of publishing configuration for clarity (microsoft#…
5488729 
…3029)

* update format of publishing profile to support hand-built environments

* apply settings keyname change to azureFunctionsPublish

* Fix microsoft#3020

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benbrown @a-b-r-o-w-n @cwhitten