fix: Maximum call stack size exceeded when open a bot

[lei9444]

Description

I have add a debug information with defName, invoked times and recursion depth in the getRef function

this three types

Microsoft.BeginDialog
Microsoft.QnAMakerDialog
Microsoft.AdaptiveDialog

are looping infinitely

The first time we open the bot, the definitionCache is empty. After doing dereference. The cache has stored the definition.

Then open a new bot again, The Microsoft.BeginDialog is stored in cache already. If we use the value and do dereference continue. There will be a infinite loop. The Microsoft.BeginDialog has a type Microsoft.IDialog, and IDialog has a Microsoft.BeginDialog type.

The schema about Microsoft.IDialog

"Microsoft.IDialog": {
			"title": "Microsoft Dialogs",
			"description": "Components which derive from Dialog",
			"$role": "interface",
			"oneOf": [
				{
					"type": "string"
				},
				{
					"$ref": "#/definitions/Microsoft.QnAMakerDialog"
				},
				{
					"$ref": "#/definitions/Microsoft.AdaptiveDialog"
				},
				{
					"$ref": "#/definitions/Microsoft.BeginDialog"
				},
				{
					"$ref": "#/definitions/Microsoft.BreakLoop"
				},

and part of Microsoft.BeginDialog are

					"oneOf": [
						{
							"$kind": "Microsoft.IDialog",
							"pattern": "^(?!(=)).*",
							"title": "Dialog",
							"$ref": "#/definitions/Microsoft.IDialog"
						},
						{
							"$ref": "#/definitions/equalsExpression",
							"examples": [
								"=settings.dialogId"
							]
						}
					],
					"title": "Dialog name",
					"description": "Name of the dialog to call."
				},

Task Item

refs #3023

Screenshots

[coveralls]

Coverage remained the same at 0.0% when pulling 1c6a9c9 on lei9444:cache into 08b8579 on microsoft:master.

[coveralls]

Coverage remained the same at 0.0% when pulling 47d48b6 on lei9444:cache into ab5cc0c on microsoft:master.

[a-b-r-o-w-n]

I'm going to look into this a bit further this morning and add some unit tests. This change seems fine to me, but I'd like to understand why.

[boydc2014]

I'm going to look into this a bit further this morning and add some unit tests. This change seems fine to me, but I'd like to understand why.

The issue is the dereference code will hit a circle once the defCache has value for certain key (which only happens the second time, we try to dereference on on exiting cache), this fix is just to clear the cache, so everytime it's a new cache and won't hit cirle.

[boydc2014]

I'm going to look into this a bit further this morning and add some unit tests. This change seems fine to me, but I'd like to understand why.

Seems like leilei added a few logs in above, it's pretty much the IDialog causing the circle.