This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: fix issue with addWebRoute() api extension method#2990
Merged
Conversation
benbrown
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum,
cwhitten,
luhan2017 and
yeze322
as code owners
a-b-r-o-w-n
suggested changes
May 11, 2020
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
Can you elaborate on the requirement for this change? I'd just like to understand what was breaking.
Composer/packages/extensions/plugin-loader/src/composerPluginRegistration.ts
Outdated
Show resolved
Hide resolved
…egistration.ts Co-authored-by: Andy Brown <asbrown002@gmail.com>
Contributor
Author
|
It was throwing an exception because Express wasn't bound to the method anymore, so it was unable to find certain internal methods. Without this, using the addWebAPI method throws this error:
This turns out to be the source problem: |
a-b-r-o-w-n
approved these changes
May 11, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Fix regression that breaks the api.addWebRoute method * Update Composer/packages/extensions/plugin-loader/src/composerPluginRegistration.ts Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a regression introduced a while ago but discovered today by a user that broke the addWebRoute method.
The method needed to be bound back to the Express object to function correctly.
closes #2990