Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: cache the url to keep the page live#2969

Merged
a-b-r-o-w-n merged 7 commits intomicrosoft:masterfrom
lei9444:routercache
May 11, 2020
Merged

fix: cache the url to keep the page live#2969
a-b-r-o-w-n merged 7 commits intomicrosoft:masterfrom
lei9444:routercache

Conversation

@lei9444
Copy link
Contributor

@lei9444 lei9444 commented May 9, 2020

Description

  1. add a session storage to store the url for every router
  2. use the cached url to recover the page

Task Item

refs #1220

Screenshots

test2

@coveralls
Copy link

coveralls commented May 9, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 0.0% when pulling fc7df58 on lei9444:routercache into 5a14ae7 on microsoft:master.

@a-b-r-o-w-n a-b-r-o-w-n added Approved to merge approved, waiting to be merged and removed Needs review labels May 11, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit de7ba6b into microsoft:master May 11, 2020
@cwhitten cwhitten mentioned this pull request May 11, 2020
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request May 15, 2020
Merged
@lei9444 lei9444 deleted the routercache branch May 21, 2020 07:05
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@lei9444 @cwhitten @a-b-r-o-w-n
fix: cache the url to keep the page live (microsoft#2969)
e1627c0 
* add sessionStoreage

* check the location when jump to begin dialog

* use props state to replace the store state

* fix lint

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@corinagum corinagum Awaiting requested review from corinagum

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved to merge approved, waiting to be merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lei9444 @coveralls @a-b-r-o-w-n @cwhitten