This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: allow dotnet build to work in project folders with spaces in their names#2958
Merged
fix: allow dotnet build to work in project folders with spaces in their names#2958
Conversation
benbrown
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum,
cwhitten,
luhan2017 and
yeze322
as code owners
carlosscastro
approved these changes
May 8, 2020
beyackle
approved these changes
May 8, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…icrosoft#2958) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a bot project or the composer app itself has a space in the path, the azurePublish functions will fail.
This patch wraps the path in quotes so that the spawned processes do not fail.
This affects azurePublish only.
Task Item
refs #2926
Related to #2926 (but does not fully address the entire issue)