Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

feat: package and schema update for 4.9.0-RC4#2911

Merged
cwhitten merged 28 commits intomasterfrom
luhan/rc1
May 8, 2020
Merged

feat: package and schema update for 4.9.0-RC4#2911
cwhitten merged 28 commits intomasterfrom
luhan/rc1

Conversation

@luhan2017
Copy link
Contributor

@luhan2017 luhan2017 commented May 6, 2020 •
edited by a-b-r-o-w-n
Loading

Description

Update sdk packages and schema for 4.9.0-RC1 which include following major changes:

Schema updates:

  1. OnCustomEvent is removed, we can use OnDialogEvent for cusmized event, we also need to update the trigger wizard @liweitian
  2. Add SkillDialog.connectionName in schema. This is to help expose the skillDialog OAuth step to the caller. @luhan2017 will follow up on the usage and docs.
  3. Add RepeatDialog.Allowloop.
  4. dialog:merge tool updated with some new schema features such as role extend which removed allof and removed $copy and $id...

Runtime updates:

  1. explicitly add Qna reference in csproj, which will fix the qna schema missing issue.
  2. add component registration part in startup.cs.
  3. OAuthInput fix for skill mode.

Task Item

fixes #2878
fixes #2942

Screenshots

@github-actions
Copy link

github-actions bot commented May 6, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 563261c on luhan/rc1 into 70b9715 on master.

@luhan2017 luhan2017 changed the title package and schema update for 4.9.0-RC1 feat: package and schema update for 4.9.0-RC1 May 6, 2020
@luhan2017
Copy link
Contributor Author

luhan2017 commented May 6, 2020

@a-b-r-o-w-n In this latest schema, the BeginDialog.options is changed to "$ref": "#/definitions/objectExpression",

which will affect the form ux like this:
Uploading image.png…

@cwhitten
Copy link
Member

cwhitten commented May 6, 2020

@luhan2017 why can't dialog:merge discover the QnAMaker component schema?

@a-b-r-o-w-n a-b-r-o-w-n self-assigned this May 6, 2020
@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as draft May 6, 2020 15:03
@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as ready for review May 6, 2020 21:48
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented May 6, 2020

@luhan2017 @liweitian I believe I have updated everything needed, including the trigger creation modal. Please confirm.

@luhan2017
Copy link
Contributor Author

luhan2017 commented May 7, 2020

I've tested this and found some issues:
1, Send A response

image

  1. Recognizer
    image

  2. SetProperties
    image

I' am wondering if there is anything wrong with my local environment, I will double check in my laptop soon.

@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented May 7, 2020

I will take a look ASAP.

@a-b-r-o-w-n a-b-r-o-w-n changed the title feat: package and schema update for 4.9.0-RC1 feat: package and schema update for 4.9.0-RC4 May 7, 2020
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented May 7, 2020

@luhan2017 I have updated to the rc4 and updated the schema. There is currently an issue building the dotnet app though that maybe you can take a look at today.

@a-b-r-o-w-n a-b-r-o-w-n marked this pull request as draft May 7, 2020 20:33
@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented May 7, 2020

@luhan2017 I took a stab at correcting the build failure (due to microsoft/botbuilder-dotnet@08590f9) with the help of @lauren-mills

@luhan2017
Copy link
Contributor Author

luhan2017 commented May 8, 2020

I've tested all the templates, they all work well. so we are ready for review on this.

@luhan2017 luhan2017 marked this pull request as ready for review May 8, 2020 05:42
@cwhitten cwhitten merged commit cc66deb into master May 8, 2020
beyackle
beyackle reviewed May 8, 2020
View reviewed changes
Composer/cypress/integration/NotificationPage.spec.ts
});

it('can show dialog expression error ', () => {
it.skip('can show dialog expression error ', () => {
Copy link
Contributor

@beyackle beyackle May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to leave this test skipped?

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Expression validation is broken currently. We decided not to block the PR and do a follow up bug fix.

scripts/generate-sdk-enum.js
Comment on lines +22 to +29
const types = Object.keys(schema.definitions).reduce((all, defName) => {

if (defName.startsWith('Microsoft.') && !defName.startsWith('Microsoft.Test')) {
all.push(defName);
}

return all;
}, []);
Copy link
Contributor

@beyackle beyackle May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't block this PR on it, but I think this could be written more easily with a .filter.

Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good suggestion. Since this is already merged, I'll probably leave as is.

This was referenced May 11, 2020
Closed
Merged
@a-b-r-o-w-n a-b-r-o-w-n deleted the luhan/rc1 branch May 18, 2020 19:46
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@luhan2017 @liweitian
@a-b-r-o-w-n @cwhitten
feat: package and schema update for 4.9.0-RC4 (microsoft#2911)
ba715ab 
* package and schema update for 4.9-RC1

* update trigger wizard (microsoft#2917)

* rename variable

* update SDKKinds enum

* fix references to removed kinds

* fix schema resolution for property editor

* do not title case the schema title

* add ability to type custom event name in trigger creation

* fix autoEndDialog type in samples

* generate sdk enum with all definitions

* Revert changes to ui schema and label map

* update ActivityTemplate to IActivityTemplate for lg fields

* resolve schema in order to determine stacking

* remove test types from sdk enum

* fix failing tests

* skip failing test

* update sdk packages and schema to rc4

* update bot start up to not use HostContext

* Update some enum to lower case and removed the recognizerset sample because it is no longer valid

* update deprecated method

Co-authored-by: liweitian <liweitian93@outlook.com>
Co-authored-by: Andy Brown <asbrown002@gmail.com>
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@benbrown benbrown Awaiting requested review from benbrown benbrown is a code owner

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@corinagum corinagum Awaiting requested review from corinagum

@srinaath srinaath Awaiting requested review from srinaath srinaath is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

2 more reviewers

@beyackle beyackle beyackle left review comments

@cwhitten cwhitten cwhitten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@luhan2017 @cwhitten @a-b-r-o-w-n @beyackle @liweitian