Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Comments

fix: use lefthand nav icon selector in NotificationPage.spec.ts#2863

Merged
cwhitten merged 5 commits intomasterfrom
beyackle/e2eNavIcon
May 2, 2020
Merged

fix: use lefthand nav icon selector in NotificationPage.spec.ts#2863
cwhitten merged 5 commits intomasterfrom
beyackle/e2eNavIcon

Conversation

@beyackle
Copy link
Contributor

@beyackle beyackle commented May 1, 2020

Description

Uses a different selector to bring up the Notifications view in our e2e tests

Task Item

closes #2866

@github-actions
Copy link

github-actions bot commented May 1, 2020

Coverage Status

Coverage remained the same at 0.0% when pulling 2eed838 on beyackle/e2eNavIcon into 2197497 on master.

@beyackle beyackle marked this pull request as ready for review May 1, 2020 22:04
@beyackle beyackle changed the title fix: [DRAFT] fix nav icon selector in NotificationPage.spec.ts fix: use lefthand nav icon selector in NotificationPage.spec.ts May 1, 2020
@cwhitten cwhitten merged commit bf5b00d into master May 2, 2020
@cwhitten cwhitten deleted the beyackle/e2eNavIcon branch May 2, 2020 00:12
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…osoft#2863)

* Update NotificationPage.spec.ts

* Update NotificationPage.spec.ts

Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants