This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Updated Composer Electron app menu#2834
Merged
tonyanziano merged 9 commits intomasterfrom Apr 29, 2020
Merged
Conversation
tonyanziano
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
corinagum,
cwhitten and
srinaath
as code owners
Member
|
Things look good except for the Electron menu item. See attached.
Can we clean this up? Can we also add a link in the help menu jumping out to the Composer docs? https://docs.microsoft.com/en-us/composer/ |
Contributor
Author
|
Doh! Yeah, I'll fix that and add a new menu item. |
Contributor
Author
|
Updated "Help" menu:
Also fixed up the labels on the Mac "App" menu |
cwhitten
approved these changes
Apr 29, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added app menu (no longer Electron default). * Added tests. * Tidied up some menu items. * Added one more help link. Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses that and explicitly sets the menu so that it only contains info / functionality relevant to Composer and not Electron.
Task Item
closes #2832
Screenshots
Windows
File
Edit
View
Window
Help
Linux
File
Edit
View'
Window
Help
Mac
I don't have a Mac, but feel free to add screen shots if you test it out!