Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Composer/packages/client/__tests__/utils/luUtil.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ describe('getReferredFiles', () => {
{ intent: 'dia2_trigger', dialogs: ['dia2'] },
{ intent: 'dias_trigger', dialogs: ['dia5', 'dia6'] },
{ intent: 'no_dialog', dialogs: [] },
{ intent: 'dialog_without_lu', dialogs: ['dialog_without_lu'] },
{ intent: '', dialogs: ['start_dialog_without_intent'] },
],
},
Expand Down Expand Up @@ -66,6 +67,10 @@ describe('getReferredFiles', () => {
luFile: 'start_dialog_without_intent',
intentTriggers: [],
},
{
id: 'dialog_without_lu',
intentTriggers: [],
},
];
const luFiles = [
{ id: 'main.en-us' },
Expand All @@ -86,6 +91,7 @@ describe('getReferredFiles', () => {
expect(config.triggerRules['main.en-us.lu'].dias_trigger.length).toBe(2);
expect(config.triggerRules['dia1.en-us.lu'].dia3_trigger).toEqual('dia3.en-us.lu');
expect(config.triggerRules['dia1.en-us.lu']['dia4.en-us.lu']).toBeUndefined();
expect(config.triggerRules['main.en-us.lu'].dialog_without_lu).toEqual('');
});

it('check the lu files before publish', () => {
Expand Down
3 changes: 2 additions & 1 deletion Composer/packages/client/src/utils/luUtil.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,10 @@ export function createCrossTrainConfig(dialogs: DialogInfo[], luFiles: LuFile[])
result[item.intent] = deduped[0];
} else if (deduped.length) {
result[item.intent] = deduped;
} else {
result[item.intent] = '';
}

if (!item.dialogs.length) result[item.intent] = '';
triggerRules[fileId] = { ...triggerRules[fileId], ...result };
});
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function ExtractIntentTriggers(value: any): IIntentTrigger[] {
for (const trigger of triggers) {
const dialogs = ExtractAllBeginDialogs(trigger);

if (trigger.$kind === SDKKinds.OnIntent && trigger.intent && trigger.actions?.length) {
if (trigger.$kind === SDKKinds.OnIntent && trigger.intent) {
intentTriggers.push({ intent: trigger.intent, dialogs });
} else if (trigger.$kind !== SDKKinds.OnIntent && dialogs.length) {
const emptyIntent = intentTriggers.find(e => e.intent === '');
Expand Down