This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Server will now dynamically mount on an open port.#2772
Merged
tonyanziano merged 10 commits intomasterfrom Apr 29, 2020
Merged
fix: Server will now dynamically mount on an open port.#2772tonyanziano merged 10 commits intomasterfrom
tonyanziano merged 10 commits intomasterfrom
Conversation
tonyanziano
requested review from
a-b-r-o-w-n,
boydc2014,
corinagum and
cwhitten
as code owners
a-b-r-o-w-n
suggested changes
Apr 24, 2020
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
I think this will mess up the dev server proxy.
beyackle
reviewed
Apr 27, 2020
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
LGTM, apart from the merge conflicts.
Contributor
Author
|
Thanks for taking a look @beyackle ! @a-b-r-o-w-n pointed out that this breaks the webpack dev server proxy that points to the server, and so I'm currently looking into how to fix that. This PR will remain in draft until then. |
a-b-r-o-w-n
approved these changes
Apr 29, 2020
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Server will now dynamically mount on an open port. * Removed dupe console log. * Addressed some PR comments (refactor). * Will only dynamically find port in production. * Fixed missing assignment. * Linting fix. Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables Composer to dynamically find an open port before starting the server.
NOTE: This has been changed to only apply to the production environment. The development environment will continue to mount on
process.env.PORTor 5000.This works in both
serverandelectron-serverTask Item
closes #2770
Screenshots
Dynamically finding a port
Starting Composer again after already having something running on 8000