Conversation
|
|
||
| builder.AddJsonFile($"ComposerDialogs/settings/appsettings.json", optional: true, reloadOnChange: true) | ||
| .AddJsonFile("appsetting.json", optional: true, reloadOnChange: true) | ||
| var configFile = Path.GetFullPath(Path.Combine(@"../settings/appsettings.json")); |
There was a problem hiding this comment.
We should not do this, we need to get the bot path first, and then search in botfolder/settings/appsettings.json, otherwise it will not working for the deployment scenario.
There was a problem hiding this comment.
And, we should consider the deployment scenario, if it is deployment, we need to get the bot and root location from appsettings.deployment.json.
There was a problem hiding this comment.
We should not do this, we need to get the bot path first, and then search in botfolder/settings/appsettings.json, otherwise it will not working for the deployment scenario.
fixed
There was a problem hiding this comment.
And, we should consider the deployment scenario, if it is deployment, we need to get the bot and root location from appsettings.deployment.json.
currently the deployment bot's path is hard-coded, do we need to make that configurable, I mean, move the 'bot': '../' to appsettings.development.json layer, and add 'bot': 'composerDialogs' to appsettings.deployment.json layer.
There was a problem hiding this comment.
yes, we should make them configurable
* fix luis appid unfound error * fix typo * use bot root to config the path of settings * differ bot to different layer * change the order of loading settings * adapt lubuild, fix settings priority Co-authored-by: Qi Kang <qika@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
3 participants
Description
Task Item
fixes #2751
Screenshots